search

openbmc / phosphor-time-manager

Local time policy and emulated host RTC manager
Apache License 2.0
6 stars 9 forks source link

Got "500 Internal Server Error" When setting NTP ProtocolEnabled #11

Closed Julia-Delta closed 1 month ago

Julia-Delta commented 1 month ago

I added the newest modified source about phosphor-time-manager (this) But I always got "500 internal server error" and set failed For example, I want to set ntp service disabled by redfish command image I got the error message, and ProtocolEnabled's value still be true image Check BMC console, I saw the systemd-timedated service reloading failed beacause of timeout And a error message "systemd-timesyncd.service: Stopping unit: Invalid argument" image

If I send the redfish command again, the value was changed and service was good. image image

Dose anyone have the same issue?

Julia-Delta commented 1 month ago

Hi @geissonator , Could you help me to verify this issue? This issue seems to this case QEMU:Romulus: 500 returned on /redfish/v1/Systems/system/ during CI testing . When I set ntp enable/disable by redfish command, I usually got 500 internel error. And auto-test got fail result as following, image

My systemd version is 254.4, and I already patched these two patch file, "Fix NTP set race condition (#922)" and " Synchronize NTP settings with systemd-timedated".

geissonator commented 1 month ago

I'm not a time-manager expert but your info above hints at not being on the latest and greatest of openbmc/openbmc. It's also not clear to me what system you're running here and if it's QEMU based or real hardware. There's not much we can do as a community if you are running downstream code or a machine that is not supported in upstream code.

With that said, there have been issues with hitting systemd with a reload at certain times during the boot of the BMC. It's a bigger issue when running in slower simulation or on AST2500 hardware. I have not seen any issues recently with the latest upstream code and our romulus QEMU model.

Julia-Delta commented 1 month ago

I used AST2500 hardware, and our team members developed on v2.14 version a lot of functions. v2.14 version was the newest stable source, this was the reason why we chosed. So updating code base is not our option.

On this version (systemd version was 254.4) , NTP enable/disable set from redfish has 500 internal server error issue. Could you ponit out any fixed patch which based on v2.14 to help me modify and finish this issue?

williamspatrick commented 1 month ago

There is no such thing as a "stable release" in the project. No one on the project currently maintains point releases. These are created just as useful points in time for people who insist on using a "release" for their work, but you're on your own for support. The majority of users of the project work off HEAD.