search

openbmc / phosphor-time-manager

Local time policy and emulated host RTC manager
Apache License 2.0
6 stars 9 forks source link

Capitalization in types doesn't match README #3

Closed robers97 closed 1 year ago

robers97 commented 6 years ago

https://github.com/openbmc/phosphor-time-manager/blob/master/types.hpp

shows what appears valid:

README references HOST

Ditto for Manual... Since NTP and BMC are capitalized this consistent, the other options are confusing.

geissonator commented 6 years ago

Can you clarify a bit or show some examples Steve? I'm not familiar with the IPMI commands from the host to configure time which I think is what you're talking about here?

robers97 commented 6 years ago

change the readme file in the root repo directory to match the case of enumerated types and it will prevent people from digging in the code for "Manual" or "Host". The examples and readme file are otherwise misleading with the all caps examples.

On Wed, Feb 14, 2018, 7:21 AM Andrew Geissler notifications@github.com wrote:

Can you clarify a bit or show some examples Steve? I'm not familiar with the IPMI commands from the host to configure time which I think is what you're talking about here?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/openbmc/phosphor-time-manager/issues/3#issuecomment-365604991, or mute the thread https://github.com/notifications/unsubscribe-auth/APhggmXRTBzUJ-KZRwpEzFNlrC-n7cfGks5tUt3UgaJpZM4SEvKL .

matthewfischer commented 1 year ago

I vote we close this. The referenced sections in the hpp file and README are long gone and I found the readme quite clear.