karma / .spec files : no tests ? - Githubissues

openbmc / phosphor-webui

Web-based user interface for managing OpenBMC systems

Apache License 2.0

37 stars 25 forks source link

karma / .spec files : no tests ? #108

Open frsauvage opened 4 years ago

frsauvage commented 4 years ago

Hi, Seems there is not unit test ? why a karma conf file ? Regards, Francine

gtmills commented 4 years ago

Hi @frsauvage,

It should be removed. It was added here, https://github.com/openbmc/phosphor-webui/commit/bbcf670a1c8c7463556eb006bc8f6bbfe29af3e4#diff-a2a3b7b0c9c3b4b93b4aebf4e3ec3cfb with the plan being unit tests would be added one day but they never have been.

Work has started on the webui vue rewrite: https://gerrit.openbmc-project.xyz/q/project:openbmc%252Fwebui-vue+status:open and https://github.com/openbmc/webui-vue and this repo has received a lot less focus. The plan is for the vue rewrite to reach feature parity with this repo by June 2020.

I would welcome changes to add unit tests or remove this file.

Thanks, Gunnar