Secondary button hover is not accessible

openbmc / phosphor-webui

Web-based user interface for managing OpenBMC systems

Apache License 2.0

37 stars 26 forks source link

Secondary button hover is not accessible #66

Closed derick-montague closed 5 years ago

derick-montague commented 5 years ago

File

app/common/styles/base/buttons.scss Line: 58 - 63

 &:hover {
    background: $lightbg__accent;
    cursor: pointer;
    background: $secbtn__bg;
    @include fastTransition-all;
  }

Issue

[ ] There are two declarations in the CSS rule with the .btn-secondary:hover selector. Remove the following declarationbackground: $lightbg__accent
[ ] Add a color to override the #fff that bootstrap sets. Should use $secbtn__text

As Is

To Be

BeccaBroek commented 5 years ago

@derick-montague

can you elaborate on "There are two declarations in the CSS rule with the .btn-secondary:hover selector. Remove the following declarationbackground: $lightbg__accent" ?