openbmc / phosphor-webui

Web-based user interface for managing OpenBMC systems
Apache License 2.0
37 stars 26 forks source link

'Edit' host name doesn't apply saved changes when the name contains a space #71

Closed jandraa closed 5 years ago

jandraa commented 5 years ago

On the server overview page, when the 'Edit' button is clicked to change the host name, there are two problems: 1) The saved host name should be pre-populated in the field, where the user can modify and give a new name.

--> The current name of the host should be displayed in the field. As soon as the user starts typing, the original name should be replaced by what the user is entering.

2) If the user includes a space in the new name, there is no error presented and a user is able to successfully save. However, the new name is not applied. Furthermore, when the user clicks 'Edit' again, this time the field is pre-populated with the new name that was just entered. Ex. If I change the name from 'witherspoon' to 'witherspoon 2', I will still see 'witherspoon'. Then, if I click 'edit' again, I will see 'witherspoon 2' in the text field.

--> If no spaces are allowed, that should be stated in the popup, the field should validate for it, and the user should not be able to save. --> If spaces are allowed, the new name should be displayed after the save.

derick-montague commented 5 years ago

@gtmills - This issue has a review in Gerrit pending and should be in current sprint and assigned to @dixsie

yoshiemuranaka commented 5 years ago

https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-webui/+/20669 Disabled button on code drop ^

Screen Shot 2019-05-01 at 11 23 02 AM

dixsie commented 5 years ago

Primary disabled button colors per style guide

Screen Shot 2019-05-03 at 10 20 09 AM Screen Shot 2019-05-03 at 10 19 55 AM