search

openbmc / phosphor-webui

Web-based user interface for managing OpenBMC systems
Apache License 2.0
37 stars 25 forks source link

GUI: Server overview page re-appears for few seconds when navigating to User account page from Server overiew #86

Closed adathatri closed 5 years ago

adathatri commented 5 years ago

The existing page reloads before navigating to the user clicked page. For eg: Suppose we are on Server Overview page and Click on Users --> Manage user accounts. Server overview page reloads and appears for few seconds before User account page shows up.

gtmills commented 5 years ago

@derick-montague @ryanarnell and I have noticed this as well.

derick-montague commented 5 years ago

This is caused by the addition of the toast messages on 12/14/18. Removing the ngAnimate from the dependencies resolves the issue. I am working on resolving this issue.

Gerrit Review: https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-webui/+/16804

derick-montague commented 5 years ago

I added transitions to the elements that are entering and leaving during route and location changes to make the transition smooth and elegant.

Review ready: https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-webui/+/21930

derick-montague commented 5 years ago

@gtmills or @edtanous - Please assign this to me and move it to the current sprint lane. Although, given that we don't plan or work in Sprints for this repo, it might also make sense to change that lane title from "Current Sprint" to "In Progress". There is a review pending...See above.