openbmc / pldm

Apache License 2.0
31 stars 40 forks source link

Check in the responder handler function, whether the response buffer is NULL #2

Closed sampmisr closed 5 years ago

sampmisr commented 5 years ago

in the encode_*_resp() functions we are checking if the response buffer is not allocated/NULL. if so then returning PLDM_ERROR_INVALID_DATA. but we are currently not checking that return code in the responder/handler functions. The responder should check the return type and send appropriate return code back to the caller. This has to be addressed throughout the repo.

dkodihal commented 5 years ago

Fixed with https://github.com/openbmc/pldm/commit/8b9766599f09b7dc5c2f1def8ff3218e95990b55.