search

openbmc / sdbusplus

C++ bindings for systemd dbus APIs
Apache License 2.0
104 stars 82 forks source link

Remove sdbus++-gendir usage from examples and tests #70

Closed SCOTT-HAMILTON closed 2 years ago

SCOTT-HAMILTON commented 2 years ago

According to this commit, sdbus++-gendir use deprecated so I propose to remove it from the tests and the examples.

williamspatrick commented 2 years ago

@SCOTT-HAMILTON Thanks for the interest. Two comments:

  1. We do all development on a Gerrit instance and not with Github PRs (https://gerrit.openbmc-project.xyz/q/status:open+project:openbmc/sdbusplus)
  2. Rather than remove all the test cases and examples, I'd prefer we convert them to use the sdbus++-gen-meson, which is suppose to be the replacement for sdbus++-gendir.