Closed williamspatrick closed 1 year ago
I am not opposed to this specific case.
However, I would be cautious about setting a precedent. Many openbmc contributors also contribute to other projects, of varying relevance. Trying to design a detailed method of accounting for this, that is also perceived as fair would be non-trivial.
Trying to design a detailed method of accounting for this, that is also perceived as fair would be non-trivial.
Yep, this is exactly what we call out in the charter for the group, and while we hope to make it better over time, we understand there are gaps, and the appeal process Patrick did is the most fair way we can think of for the moment (everything can always been improved though if you have ideas).
In 2022H1, Peter did significant contributions
I do see he has many contributions to facebook/openbmc, and while not directly applicable, does make his input valuable in terms of differences in implementation, and how LF openbmc can improve. I see no problems adding him to rollcall.
👍
I am not opposed to this specific case.
However, I would be cautious about setting a precedent. Many openbmc contributors also contribute to other projects, of varying relevance. Trying to design a detailed method of accounting for this, that is also perceived as fair would be non-trivial.
On second thought, if you guys prefer, we can wait and re-evaluate this in another 6 months. I'm expecting to contribute more to the actual LF OpenBMC codebase in the near future, up until now I've just been mostly focused on QEMU and FB OpenBMC.
I have opinions on how to steer QEMU to support OpenBMC, but at the moment, I don't really have that many opinions on steering the LF OpenBMC project itself, and like you say, it might not be a very good precedent to set.
In some regards I opened this proactively because there are a number of other people who regularly contribute to untracked areas that did not petition last go-around for inclusion. I picked Peter since we both work for the same company and to, hopefully, give indication to all those other people that this is perfectly acceptable to request. Plus, as we discussed when we wrote the charter, if we don't know where those other contributions are it is hard for us to add them to the tooling.
If Peter were intending to join the TOF (which I don't think he is), he'd probably need to be able to better articulate opinions on steering the project, but I don't think mostly contributing to QEMU should preclude him (and others in similar situations) from being able to give voice to select their TOF representatives.
The TOF membership document explicitly says the following:
Currently, work on the following projects requires an explicit petition for recognition of ToF membership eligibility:
Linux
u-boot
QEMU
bitbake
open-embedded
Poky
We recognized at the time that we wrote it that Linux kernel and QEMU were two areas especially where people might specialize, and do work that is highly meaningful to the project overall, but the data was outside Gerrit.
Relevant section of the documentation: https://github.com/openbmc/docs/blob/master/tof/membership-and-voting.md#openbmc-development-community
The relevant election has come and gone so I believe we can close this.
@peterdelevoryas did not qualify using our current tools because his contributions are outside of Gerrit. In 2022H1, Peter did significant contributions to upstream QEMU for Aspeed support that is useful to all companies. I've filtered out any machine-specific commits in this list:
With this data in mind, I'd like to petition Peter be added to the roll-call for 2022H2's TOF elections.