openbmc / technical-oversight-forum

6 stars 1 forks source link

Request to create a new repository for License service support #28

Closed raviteja-b closed 1 year ago

raviteja-b commented 1 year ago

Design Document License service design proposal : https://gerrit.openbmc.org/c/openbmc/docs/+/64710

D-bus Interfaces : https://gerrit.openbmc.org/c/openbmc/phosphor-dbus-interfaces/+/64485/

Redfish license service schema: https://redfish.dmtf.org/schemas/v1/LicenseService.v1_1_0.json https://redfish.dmtf.org/schemas/v1/License.v1_1_1.json

Naming List at least two possible names for this repository. phosphor-license-manager phosphor-license-service

Maintainers List the maintainer(s) for this repository. Ravi Teja raviteja28031990@gmail.com Sunitha Harish sunithaharish04@gmail.com

raviteja-b commented 1 year ago

Hi all

This is a request for creating new repository called phopshor-license-manager to implement license feature in OpenBMC. Licenses are supposed to be uploaded by clients to unlock some of host hardware resources like processor, memory and cores etc. Redfish already supports LicenseService schemas. Plan is use to this license manager repository for implementation of license d-bus app which hosts license install method and license entry objects and Redfish LicenseService will be implemented to support LicenseService CURD operations under bmcweb using this D-bus app as per redfish schemas.

williamspatrick commented 1 year ago

I think we need more of a design here. How does the license server work and how are other repositories expected to interact with it?

I am assuming you want more than “upload a file” and “expose the parsed contents of that file over Redfish”. You actually want the BMC and/or other firmwares to do the enforcement of the license… how are you proposing this to work?

raviteja-b commented 1 year ago

I think we need more of a design here. How does the license server work and how are other repositories expected to interact with it?

I am assuming you want more than “upload a file” and “expose the parsed contents of that file over Redfish”. You actually want the BMC and/or other firmwares to do the enforcement of the license… how are you proposing this to work?

Hi Patrick License service D-bus app will be using PLDM interfaces to send this license to Host and Host installs this given license & sends a json file of installed licenses to BMC through PLDM. License D-bus app parses this license json content and populates D-bus objects.

williamspatrick commented 1 year ago

License service D-bus app will be using PLDM interfaces to send this license to Host and Host installs this given license & sends a json file of installed licenses to BMC through PLDM. License D-bus app parses this license json content and populates D-bus objects.

These are the kind of details I'd expect to see in a design document. Please follow the design document template, upload to Gerrit, and update your repository request with a pointer to this.

As the repository request issue says:

Provide a link to the document outlining why this repository is required.

Maybe we should be clearer but we were expecting this to be a link to a design document proposal.

amboar commented 1 year ago

Maybe we should be clearer but we were expecting this to be a link to a design document proposal.

I've pushed a patch that hopefully helps:

https://gerrit.openbmc.org/c/openbmc/technical-oversight-forum/+/64591

@raviteja-b I think it would be helpful to assume that patch above will be merged and front-run it by adding the design document link and appropriate maintainer evidence to this issue as soon as possible.

However, another hurdle you have to clear is that the problem of license management has been discussed previously in the community and wasn't very well received. Please read through the discussion and argument across all responses to this thread:

https://lore.kernel.org/openbmc/CAMhqiMoFAHcUk0nO_xoOubcZqF_dPDFweqsttTULRJK38o1Ung@mail.gmail.com/

From my perspective, you must articulate what you think is different this time around, and why those differences warrant an expectation of a different outcome.

raviteja-b commented 1 year ago

License service D-bus app will be using PLDM interfaces to send this license to Host and Host installs this given license & sends a json file of installed licenses to BMC through PLDM. License D-bus app parses this license json content and populates D-bus objects.

These are the kind of details I'd expect to see in a design document. Please follow the design document template, upload to Gerrit, and update your repository request with a pointer to this.

As the repository request issue says:

Provide a link to the document outlining why this repository is required.

Maybe we should be clearer but we were expecting this to be a link to a design document proposal.

sure Patrick, will push a design proposal

raviteja-b commented 1 year ago

Maybe we should be clearer but we were expecting this to be a link to a design document proposal.

I've pushed a patch that hopefully helps:

https://gerrit.openbmc.org/c/openbmc/technical-oversight-forum/+/64591

@raviteja-b I think it would be helpful to assume that patch above will be merged and front-run it by adding the design document link and appropriate maintainer evidence to this issue as soon as possible.

However, another hurdle you have to clear is that the problem of license management has been discussed previously in the community and wasn't very well received. Please read through the discussion and argument across all responses to this thread:

https://lore.kernel.org/openbmc/CAMhqiMoFAHcUk0nO_xoOubcZqF_dPDFweqsttTULRJK38o1Ung@mail.gmail.com/

From my perspective, you must articulate what you think is different this time around, and why those differences warrant an expectation of a different outcome.

Sure @amboar. will try capture all these details in a design document.

raviteja-b commented 1 year ago

License service D-bus app will be using PLDM interfaces to send this license to Host and Host installs this given license & sends a json file of installed licenses to BMC through PLDM. License D-bus app parses this license json content and populates D-bus objects.

These are the kind of details I'd expect to see in a design document. Please follow the design document template, upload to Gerrit, and update your repository request with a pointer to this. As the repository request issue says:

Provide a link to the document outlining why this repository is required.

Maybe we should be clearer but we were expecting this to be a link to a design document proposal.

sure Patrick, will push a design proposal

Here is design doc https://gerrit.openbmc.org/c/openbmc/docs/+/64710

williamspatrick commented 1 year ago

Please reopen when the design document is complete. There are at least 3 sections at the end that aren’t filled in.