Serial console opened in new tab shows spurious "must be powered on to connect" error - Githubissues

openbmc / webui-vue

Web-based user interface built on Vue.js for managing OpenBMC systems

https://openbmc.github.io/webui-vue/

Apache License 2.0

56 stars 55 forks source link

Serial console opened in new tab shows spurious "must be powered on to connect" error #97

Closed zevweiss closed 1 year ago

zevweiss commented 2 years ago

Describe the bug Opening the SoL console in a new tab displays an error message saying "System must be powered on to connect" even when the system is powered on, and shows the status as "Disconnected" while the main SoL page shows "Connected". The SoL console functions normally despite the error, but it's confusing & misleading.

To Reproduce Steps to reproduce the behavior:

With the host powered on, go to the Operations -> SoL console page
Click on the "Open in new tab" button
Observe the "System must be powered on to connect error"

Expected behavior No spurious error messages

Screenshots sol-console-error

Desktop (please complete the following information):

OS: Linux, MacOS
Browser: Firefox, Chrome
Version: MacOS Chrome 105, MacOS Firefox 87, Linux Firefox 91

wayne-tung commented 1 year ago

In commit: 4dd7eabfa4476e264e051dc0178a333452a6b175

We changed the "getServerStatus" to "getSystemInfo" in GlobalStore.js

We still used old store API "global/getServerStatus" to get current server status in SOL page "created" function.

kirankumarb07 commented 1 year ago

Gerrit Link : https://gerrit.openbmc.org/c/openbmc/webui-vue/+/60720

kirankumarb07 commented 1 year ago

Please help to close this issue as https://gerrit.openbmc.org/c/openbmc/webui-vue/+/60720 PR merged.

@gtmills @sandeepasingh116 @zevweiss

zevweiss commented 1 year ago

Thanks for the fix @kirankumarb07.