openboard-team / openboard

GNU General Public License v3.0
2.56k stars 253 forks source link

feature request: add dictionaries from the application #219

Open elig0n opened 3 years ago

elig0n commented 3 years ago

most keyboards support selecting and installing dictionaries from their settings, why shouldn't this one too ?

mirsella commented 3 years ago

because adding feature is not always easy. you can add dict but you need to recompile the app

sabzo commented 3 years ago

@mirsella I made a new dict file and installed in res/raw and built the app on Android Studio but they new dictionary isn't showing on the language settings. I also erased a few dictionaries from res/raw to see if they would be removed from the app, but this didn't work either. What is the correct process of "recompiling" the app so that dicts in res/raw show?

mirsella commented 3 years ago

I didn't looked into it, but the easiest way know would be to just replace a already existing language you will not use. if you want to add a new one there is probably others places to add it too.

sabzo commented 3 years ago

@mirsella how do I find those other places? The README only lists one location

mirsella commented 3 years ago

I'll look into it when I got home, but still the easiest would be to just replace a layout you are not using by your custom layout

if you are confortable with a shell, you can try to grep a filename of a layout to see how they are hard coded

mirsella commented 3 years ago

so there is multiple file to change.

fd colemak : app/src/main/res/xml/kbd_colemak.xml app/src/main/res/xml/keyboard_layout_set_colemak.xml app/src/main/res/xml/rowkeys_colemak1.xml app/src/main/res/xml/rowkeys_colemak2.xml app/src/main/res/xml/rowkeys_colemak3.xml app/src/main/res/xml/rows_colemak.xml app/src/main/res/xml-sw600dp/rows_colemak.xml

give me all these files. so you can see how it's organized. the organization is complexed so good luck.

and grep colemak also output a lot of file. it gives multiples file too where colemak is set, so you can try to add your new layout in every one of them.

good luck. I want to add a custom colemak-dhm layout one day, might try to do it in this Christmas holiday.