search

openboard-team / openboard

GNU General Public License v3.0
2.51k stars 250 forks source link

Support for Korean #24

Open ghost opened 4 years ago

ghost commented 4 years ago

add Korean support as its the main thing keeping me away from uwing it full time

Lee0701 commented 3 years ago

I have added Korean input logic and layouts on my fork but have no idea how to generate a dictionary. Already tried to follow instructions on aosp-dictionary-tools, but dicttool_aosp.jar requires me a native library that they haven't provided nor have instructions on building. Am I missing something?

EDIT: Nevermind, seems like I missed adding a header

Koregit commented 3 years ago

Hi, how can I add Korean keyboard to Openboard? Thanks 감사합니다

Lee0701 commented 3 years ago

Hi, how can I add Korean keyboard to Openboard? Thanks 감사합니다

You could clone and compile the hangul branch on my fork of this repo of this repo although it might not be stable.

Koregit commented 3 years ago

Hi, First of all I want to say that I have no idea how to compile code. What I did, I installed Android Studio, loaded the unzipped openboard-hangul folder and clicked on ‘run app’. This installed the openboard-hangul to my device and replace the original openboard app. I have tested this fork with several apps and so far it works perfectly! Thanks a lot!

Is there a reason you are not including your code into openboard instead of releasing a fork?

Lee0701 commented 3 years ago

@Koregit Glad to hear that! I haven't released my fork nor made a pull request for including it to the main repo. It's just under development. Still there is a need to optimise and debug (e.g. NFD normalisation before dictionary search, dictionary speed improvement like adding composite word support?)

joopdo commented 2 years ago

@Lee0701 Thank you for the fork!

nandangowda21 commented 1 year ago

how can i convert event folder kotiln file to java file @Lee0701

tmvkrpxl0 commented 6 days ago

@Lee0701 Is there progress on this issue? The dictionary file on your fork works better than this one and I think it'd be beneficial for all other AOSP keyboard based forks if it's contributed to here

Lee0701 commented 5 days ago

@Lee0701 Is there progress on this issue? The dictionary file on your fork works better than this one and I think it'd be beneficial for all other AOSP keyboard based forks if it's contributed to here

Unfortunately the new dictionary uses extra NFD normalization process for better performance as you mentioned, so I doubt it would work without being decoded by the custom dictionary class. But it could be as easy as a drop-in replacement to use it.

btw I had my fork rebased to openboard main here. Please remind me if PR is needed.

tmvkrpxl0 commented 5 days ago

Neat, I actually needed this as other keyboard apps are funky when writing korean.