openboard-team / openboard

GNU General Public License v3.0
2.56k stars 253 forks source link

Automatic word learning not working #726

Open aprunai opened 1 year ago

aprunai commented 1 year ago

Describe the bug When typing a new word, it is not added automatically to the dictionary and does not appear in suggestions.

EDIT: the app's behaviour is correct if the "automatic correction" option under "text correction" in preferences is set to "on".

To Reproduce Steps to reproduce the behavior:

  1. Type a word that is not in the dictionary and press enter.
  2. Start typing it again.

Expected behavior OpenBoard should have learned the new word and put it among suggestions.

Smartphone:

Additional context If Openboard's spellchecker is turned on in system preferences, every new word is underlined as if it was wrong, and pressing on it prompts a requester to add it to the dictionary; but this is too cumbersome and complicated.

Mrnofish commented 1 year ago

Working for me in English after repeating the same word twice.

mrx23dot commented 1 year ago

Repeating didn't work for me, type 'HP' exit given app, reopen it, type HP again, still not in suggestions. v1.4.5 on android12

How do I manually add the new words? On gBoard I can simply tap on word.

aprunai commented 1 year ago

I found out recently that Openboard works as expected if I turn the "automatic correction" under "text correction" in preferences on. Learning of new words then works regularly with spellchecker turned off, as well as word prediction. I opened the issue since, being not fond of that option - and thus never activating it, I thought learning/prediction were broken: it appears to be a bug in activation of these features instead.

mrx23dot commented 1 year ago

I retested latest release with "automatic correction" on, but I need spellchecker on.

'Hi hugy hugy word hugy' last word wasn't in suggestion list (never learnt), even when I expand the list with long press. does this work for you?

aprunai commented 1 year ago

It does for me with both spellchecker enabled and disabled.

Screenshot_20230217_122316

mrx23dot commented 1 year ago

Oh yeah, it shows up for me too when I not finish the word, just type 'hug'. Thanks!