search

openboard-team / openboard

GNU General Public License v3.0
2.59k stars 254 forks source link

Wrong behavior of a key with bépo layout #801

Open sronayette opened 1 year ago

sronayette commented 1 year ago

Describe the bug With the french bépo layout, a long press on the letter "é" makes a ",è", where I would expect simply an "è" (with the option "Toujours afficher la ligne de chiffre" (always display line of digits))

To Reproduce Steps to reproduce the behavior:

  1. French bépo layout
  2. Always display the line of digit
  3. Long press en "é"
  4. You get ",è"

Expected behavior A long press on "é" should make an "è", well I suppose. I don’t see the reason for the ",è". A workaround is to get the "è" with a long press en "e". Furthermore from what I see, the long press on "é" should also offer the "\"

Screenshots

Screenshot_20230621-144138_Message

Smartphone (please complete the following information):

Ammako commented 1 year ago

https://github.com/openboard-team/openboard/blob/c3772cd56e770975ea5570db903f93b199de8b32/app/src/main/res/xml/rowkeys_bepo1.xml#L29

I don't understand why it doesn't work though

Maybe \ needs to be defined with a key code instead of escaped, but I don't know what that key code would be

tbh it might be that \ ends up erroneously escaping the comma, so I think the only option would be to define it directly with a key code

Ammako commented 1 year ago

It's unicode hex values, I think. Try changing this to "\,è"

If you need help building from source I'll be happy to instruct further. The chances of a maintainer picking this up and making the chances + making a new release with it are fairly low at the moment, you'd be waiting a while.

sronayette commented 1 year ago

Thank you Ammako for looking into this. I’ll see if I can make the modification and build from source. I’ll give it a try... when I find the time.

S.