add rust and js lints

[mschneider]

can you push a complete prettier config file and lint github action? this way formatting changes wont be an issue going forward

[Aursen]

Do you want also a CI lint check ?

[mschneider]

yeah ideally, used this one before https://github.com/blockworks-foundation/mango-ui-v3/blob/main/.github/workflows/node.js.yml

[Aursen]

Ok I added but I cannot test the workflow

[mschneider]

kicked it off

[mschneider]

looks like prettier broke now because of working directory change, it'd be good to manage node & cargo in separate jobs to get parallel execution and not run into cache & memory limits

[Aursen]

Do you want me to put rust fmt and clippy in the tests workflow or I separate in 3: tests, Rust lint, Js lint

[mschneider]

separate is good, so it's easy to see at one glance and also everything runs in parallel

[Aursen]

I hope it will be good now

[mschneider]

sorry, but i think you have a syntax error in one of the yaml files

[Aursen]

Sorry I will fix

[silas-x]

Was going to have a look at these jobs today, but good to see this is in hand! @Aursen, given the use case for prettier is about 5% of the codebase in the test files, suggest splitting into a separate workflow that is only triggered when changing the tests

[Aursen]

I need some help, I'm really not an expert with GitHub actions

[silas-x]

No worries! Lots of good fmt/clippy fixes in this PR. Suggest removing the prettier step and merge the rest? Can pickup tmw.

[Aursen]

Normally everything is good

[mschneider]

hooray!