search

openbrewerydb / openbrewerydb-fastapi

Open Brewery DB REST API using FastAPI
MIT License
3 stars 1 forks source link

Endpoint testing. #23

Closed milsman2 closed 1 year ago

milsman2 commented 1 year ago

Skeleton for API response. Please verify this is good so far @chrisjm.

milsman2 commented 1 year ago

Thanks so much, @milsman2! Cheers! 🍻

A couple of updates requested, see comments.

Also, maybe it's not a big deal, but I'd like to not include requirements if they aren't actually needed. That said, I'm totally out of date with my best practices Python dev knowledge, so if everything you added is just normal these days, please ignore this comment. 😄

Understood. However, most apps are also made with being containerized in mind as well. For that to be dependable, I think it's good practice to have a list of frozen requirements that the image builder can utilize, IMO.

milsman2 commented 1 year ago

Understood. However, most apps are also made with being containerized in mind as well. For that to be dependable, I think it's good practice to have a list of frozen requirements that the image builder can utilize, IMO.

Oh, totally, and I'm sorry that my comment was confusing. 😅 I only meant that I wanted to ensure greenlet, black, and the other additions to the requirements.txt were required for whatever reason because they don't seem to be referenced in the changed code.

That said, very minor and all good! Thank you for the updates! 👍

Ah! Fair enough. Some are dependencies for things I'll be adding soon like the actual db calls, more async, etc.