openbridge / nginx

NGINX Accelerated! This is a Docker image that creates a high performance (FAST!), optimized image for NGINX for use with Redis and PHP-FMP. Deliver sites and applications with performance, reliability, security, and scale. This NGINX server offers advanced performance, web and mobile acceleration, security controls, application monitoring, and management.
https://www.openbridge.com/
MIT License
233 stars 53 forks source link

monit always failed at 8080 port check #59

Closed huynq2007 closed 4 years ago

huynq2007 commented 4 years ago

Describe the bug When you run with the html config. monit will run conf/html/monit/check_nginx script to check upstream proxy port. Since the proxy is local to the container but monit run the check with NGINX_SERVER_NAME address. There is possibility that it will be failed.

To Reproduce

  1. Confirm the conf/html/monit/check_nginx
  2. You will see the command if failed port 8080 for 3 cycles then exec "/usr/bin/env bash -c '/usr/sbin/nginx -s stop'" (line 36)

Expected behavior remove this line as it is supposed that 8080 port will always be locally opened. Therefore, not necessary to check this port.

Screenshots The monit web interface show 8080 port check will always be failed.

Screen Shot 2020-04-14 at 13 44 41
tspicer commented 4 years ago

I think this was an errant addition as I do not have it locally. I will remove.

tspicer commented 4 years ago

If you can confirm this fixes your issue I will close. Thanks

huynq2007 commented 4 years ago

conf/html/monit/check_nginx does have that check but conf/php/monit/check_nginx doesn't Therefore the issue only happened when we running in html config I remove that line and the issue is fixed.