openbroadcaster / obplayer

:radio: OBPlayer Streaming Automation Playout with CAP EAS Alerting
https://openbroadcaster.com
GNU Affero General Public License v3.0
120 stars 46 forks source link

LA not switching to Fall Back Media #16

Open radiorob opened 8 years ago

radiorob commented 8 years ago

When LA gets to the end of a scheduled LA show and there is nothing else scheduled, it should sense it is stuck playing nothing and should kick into a DPL (if there is one) and if no DPL start playing local Fall Back Media. Presently at end of LA, it gets stuck, screen blinks\refreshes, dead air. When LA is stuck, pressing > PLAY starts the fall back media.

iesfausti commented 8 years ago

Hi, again. Thanks for the fast support, and sorry for my english, (Hola from Valencia, ES) I think I found a clue where this issue begins. If in a the middle of a schedulled playlist I break Ctr-C *2 the obplayer and restart it, the show continues, but at the end if nothing its programmed this bug shows up, and no fall back , no, nada.

Silly patch, not a real solution: Put in the beggining of the function _playnext in scheduler.py line 173. self.ctrl.stop_requests() self.ctrl.add_request(media_type='break', end_time=self.end_time(), title = "break (filling spaces)")

UPDATE!: Just only one case, this case breaking in he middle of a show...the player fail me again after several shows...argh.

transistorfet commented 8 years ago

Hello from Vancouver, Canada =)

The problem here is moreso one of user interaction. The existing behaviour is actually how we designed it at the time as a compromise, and a proper fix requires some major work on the LiveAssist.

The problem is that once the LA show has ended and the fallback player or default playlist takes over to fill the air, there's no way for the radio host to interrupt that and go back to their show. The show has ended and the scheduler has moved on to the next show. There's also no reliable way for the LA to detect that the show has ended and the radio host has walked away (and thus it is safe to switch). It's possible for the radio host to let the playlist finish and then talk a bit more before ending the show, or they could accidentally click on the last item causing the show to end, thus locking them out. So the decision was made to not lock out the host, even if that means playing dead air for the remainder of the slot.

Perhaps a better way of doing this would be to add a button to the LA to go live vs playing the DPL, and the host will have to click the button when they're ready. If they fail to show up to do their show, it would play fallback or DPL content for the whole slot. This would require some major work though, given how the live assist and schedule system is currently written. The LA was originally made on a very small budget, and the rest of the player code has been rewritten since then. The LA could do with a lot of work really. Currently it's not a high priority on my to do list, but I will get to it eventually.

BD-Engineering commented 3 years ago

How much closer are you after cery nearly 5 years?

I really like the way LA works for doing remotes around town live.

Would be nice if we could end any time we wanted without someone having to make sure there is not dead air.

radiorob commented 8 months ago

Bug - When get to the end of a LA PL, player stops, should try DPL or FB. Plays silence

radiorob commented 8 months ago

How much closer are you after cery nearly 5 years?

I really like the way LA works for doing remotes around town live.

Would be nice if we could end any time we wanted without someone having to make sure there is not dead air.

5 years still no fix. What are you using presently that works?

radiorob commented 8 months ago

@brookgagnon advises when there's someone actually doing the show (LA PL), we don't want DPL to start playing before their show time ends.

radiorob commented 7 months ago

Rule if there is a a breakpoint at end of LA PL, pause so host can finish end of show, if there is no breakpoint at end of PL and time remaining to fill, play DPL and if that is missing go to FB media.