openbudgets / Code-lists

Code list in fiscal data sets
0 stars 3 forks source link

CPC: concepts sharing the same prefLabel #17

Closed jindrichmynarz closed 8 years ago

jindrichmynarz commented 8 years ago

CPC contains several concepts that share the same preferred label. For example, <http://data.openbudgets.eu/resource/codelist/cpc/98>, <http://data.openbudgets.eu/resource/codelist/cpc/980>, <http://data.openbudgets.eu/resource/codelist/cpc/9800>, and <http://data.openbudgets.eu/resource/codelist/cpc/98000> all share the preferred label "Domestic services"@en. This is considered to be a bad practice (see here). Is this issue a problem of the source data or the conversion?

skarampatakis commented 8 years ago

As you can see this is a fault of the source codelist itself

http://ec.europa.eu/eurostat/ramon/nomenclatures/index.cfm?TargetUrl=LST_CLS_DLD&StrNom=CPC_2&StrLanguageCode=EN&StrLayoutCode=HIERARCHIC#

and occurs on multiple codes and some other codelists also. That's because some codes have the same description on multiple levels.

A possible solution to this could be to concatenate the description with the level so every label would be unique. Or we could leave them as is.

pwalsh commented 8 years ago

This is very, very common across budgetary classification in the real world, and is not a "fault" - it is a property of the data itself.

skarampatakis commented 8 years ago

I couldn't agree more but also my thought on this is that these structures should be defined better, as this report also recommends

http://ec.europa.eu/internal_market/publicprocurement/docs/rules/cpv/121219_report-review-cpv-codes-functioning_en.pdf

pwalsh commented 8 years ago

Well, yeah, the world should be different in many ways :). Until then....

jindrichmynarz commented 8 years ago

OK, thanks for the explanation. This might make linking external datasets more ambiguous, because we would need to choose at what level to make a link based on a match on label shared by multiple concepts in the code list's hierarchy.