openbullet / OpenBullet2

OpenBullet reinvented
https://docs.openbullet.dev/
MIT License
1.74k stars 464 forks source link

[Bug]: Race Condition in stacker #1069

Open mastercho opened 1 month ago

mastercho commented 1 month ago

This issue respects the following points:

Description of the bug

When you make changes on config and click debug in stacker but for some reason its keeps old inputs and change will be affected on second clicking on debug

Reproduction steps

Make changes to config, click debug and see if changes are affected or not

What is the current bug behavior?

.

What is the expected correct behavior?

To have changes saved on clicking debug

Version of the client

0.3.1

Type of client

Web client

Environment

- OS: Windows 10
- Virtualization:
- Browser: Chrome

OpenBullet2 logs

No response

Client / Browser logs

No response

Relevant screenshots or videos

No response

Relevant LoliCode if needed

No response

Additional information

No response

tcortega commented 1 month ago

angular moment

openbullet commented 1 month ago

It's because the config is saved upon blur of the input elements, so the request to start debugging might sometimes come first if you directly click on the Debug button without first clicking elsewhere, we just need to add an additional save request before starting the debugger, and then start the debugger upon its completion. This could be a good first issue for a new contributor.