opencabstandard / opencab

A standard for communication between in-cab trucking apps.
https://opencabstandard.org
MIT License
1 stars 3 forks source link

Fix XML examples that should use actual strings, not constant references #16

Closed pnc closed 1 year ago

pnc commented 1 year ago

It goes without saying that the XML files cannot use the Java constants for these strings.

The example projects were fixed in https://github.com/opencabstandard/opencab/commit/8126a2288ce602881b683f7dc02186026acfff28

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
opencab ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 7, 2023 1:32pm
pnc commented 1 year ago

I tend to think the example should now include

<action android:name="org.opencabstandard.ACTION_IDENTITY_INFORMATION_CHANGED" />

too for completeness.

pnc commented 1 year ago

cc @sebastian-valentin who I finally added to maintainers list.