opencaching / okapi

A common API for all National Opencaching.XX sites
22 stars 20 forks source link

Edit recommendations and ratings #563

Closed following5 closed 6 years ago

following5 commented 6 years ago

So far, users must delete and resubmit their 'Found it' log to change or withdraw a rating. Recommendations can be withdrawn only on the OC website, or by deleting and resubmitting the 'Found it' log(s).

Would be nice if all this can be done directly via Okapi. Either via services/logs/edit or separate or both.

In the services/logs/submit code there is the error message "You have already rated this cache once. Your rating cannot be changed", which is not exactly true - see above. I'm not sure if this means that services/logs/submit does not implement it, or that re-rating a cache is deprecated at OCPL ...?

kojoty commented 6 years ago

So far, users must delete and resubmit their 'Found it' log to change or withdraw a rating.

that's right.

Recommendations can be withdrawn only on the OC website, or by deleting and resubmitting the 'Found it' log(s).

OCPL allow to withdraw recommendation (green star) directly - check the https://opencaching.pl/MyRecommendations/recommendations page

Would be nice if all this can be done directly via Okapi. Either via services/logs/edit or separate or both.

could be :)

In the services/logs/submit code there is the error message "You have already rated this cache once. Your rating cannot be changed", which is not exactly true - see above. I'm not sure if this means that services/logs/submit does not implement it, or that re-rating a cache is deprecated at OCPL ...?

In my (personal) opinion re-rating a log is not much important feature but I can't see any disadvantages of allowing user to change their rate assigning to the cache. For now OCPL doesn't allow to do that directly but it is OK to add such option in OKAPI.

following5 commented 6 years ago

Thanks for clarification. There was even a comment in OKAPI source code: "Also, once submitted, the rating can never be changed. It surely feels quite inconsistent ..."

Agree that this is low prio. Revoking recommendations is more important, because they are limited - users may need one for another cache.

OCDE allows multiple founds per cache, therefore there is a second way of revoking: Withdraw the recommendation with another found log. This is also missing in OKAPI.

following5 commented 6 years ago

services/caches/edit can now

Regarding late-adding or changing ratings, there are pros and cons. Worst case, a user who got in trouble with some owner may misuse it and rate 1 for all the old founds.

Also, non-rating is always intentional, because OCPL asks for a rating; and the first impression is often the best. So there is little point in adding a rating later.

Will leave it this way. If someone thinks ratings should be editable, please reopen. :-)

following5 commented 6 years ago

Btw,

Either via services/logs/edit or separate or both.

Decided for services/logs/edit only (instead of adding it to services/caches/mark). Reason: If multiple founds are allowed for the same cache, then the recommendation or rating may be assigned with one of the founds; so it's log-related (and we may need to know the log UUID. OCDE does that for recommendations.

following5 commented 5 years ago

At OCPL there is the open issue https://github.com/opencaching/opencaching-pl/issues/1381 for editing cache ratings.