Cache type changes at OCPL - Githubissues

opencaching / okapi

A common API for all National Opencaching.XX sites

22 stars 20 forks source link

Cache type changes at OCPL #595

Open andrixnet opened 5 years ago

andrixnet commented 5 years ago

Handles changes described here: https://github.com/opencaching/okapi/issues/594 and is paired with this PR at OCPL: https://github.com/opencaching/opencaching-pl/pull/2087

following5 commented 5 years ago

This PR changes the internal OCPL ID of Moving caches from 8 to 9. Please be aware of the consequences of such renumbering:

OCPL code needs to be examined carefully for any references to cache type 8, changing it to 9. There are many places in OC code, including templates and translation tables, where cache type IDs are referenced.
Synchronous update of OKAPI, OCPL code and contents of 'caches' and 'cache_types' tables must be done on all OCPL sites.

I don't see any benefit by this renumbering and recommend not to do it - it just produces additional work and can introduce bugs.