opencaching / opencaching-pl

The source code of Opencaching.PL (and some other domains)
https://opencaching.pl/
GNU General Public License v3.0
22 stars 33 forks source link

Consolidate GPX and GPC-GC #1855

Open following5 opened 5 years ago

following5 commented 5 years ago

There are two GPX exporters in OCPL code: GPX-GC ("Groundspeak GPX") and GPX. Does someone remember what's the intended difference of both? Are there compability problems of "GPX-GC" with some devices? Is it to minimize data amount when downloading many caches? (see #1006 - Gpx export memory issue)

OCDE has only one GPX format, which is Groundspeak compatible and works with all devices. But it limits the download to max. 500 caches.

GPX-GC download is linked here:

GPX download ist linked here:

Important improvements are missing in GPX. The usual problem with redundant copy-and-past source code (lib/search.gpx.inc.php vs. lib/search.gpxgc.inc.php).

I suggest to consolidate that, either merge both to one module which produces both formats, or fix GPX-GC if it has issues with some devices and discard GPX.

following5 commented 5 years ago

Just noticed that GPX and GPX-GC have different mappings for special OC cache sizes.

GPX:

GPX-GC:

I would prefer to map Very Large always to Large. But am not sure about Nano.

following5 commented 5 years ago

Another option would be to discard the legacy GPX code and rebase all GPX download on OKAPI. Additional [internal] switches may be added to OKAPI GPX service, if necessary, so that the output will have the desired format and may contain more than 500 caches.