Can't add webcam to geopath

opencaching / opencaching-pl

The source code of Opencaching.PL (and some other domains)

https://opencaching.pl/

GNU General Public License v3.0

22 stars 33 forks source link

Can't add webcam to geopath #2292

Open kojoty opened 3 years ago

kojoty commented 3 years ago

There is problem with adding cache of type webcam to geopath. For now geocaches of type:

webcam
owncache
event Can't be added to geopath. Additionally this is not handled properly as system doesn't show any error...

andrixnet commented 3 years ago

Whether or not a cache of a certain type should be allowed to be added to a geopath is debateable (at rules level). IMO technically all cache type should be allowed, and if the rules say otherwise, then it should be a site configuration for this.

Regarding type discussions, my opinions:

webcam - yes (don't see why not)
owncache - maybe (debateable; should be stationary or otherwise easy to find within the geopath context, at least)
event - no, or maybe. (if allowed, perhaps exempt from the geopath completion calculation. but this adds compexity)

kojoty commented 3 years ago

Hi Andrei,

Previously it was a silent limitation in the code. Now I've moved it to config and it can be modify as a per-node policy - see this: https://github.com/opencaching/opencaching-pl/pull/2293/files#diff-b59b58bd3b7503bb9ea8e55a6f4940a28888a2eb1dbd11e6f646902c70a11f8cR35

kojoty commented 3 years ago

PR https://github.com/opencaching/opencaching-pl/pull/2293 containing the fix for this issue

andrixnet commented 3 years ago

I just remembered: IMO "moving cache" type should also be prevented from being part of a Geopath. For obvious reasons :-)