search

opencaching / opencaching-pl

The source code of Opencaching.PL (and some other domains)
https://opencaching.pl/
GNU General Public License v3.0
22 stars 33 forks source link

CacheSetAdmin - cacheSetsToArchive visibility question #2353

Open rapotek opened 2 years ago

rapotek commented 2 years ago

In src/Controllers/Admin/CachesetAdminController the only requirement for cacheSetsToArchive method is for user to be logged in. That means any logged in user can view "Degraded GeoPaths", no OC Team member being is required. Is it on purpose and correct or an oversight?

stefopl commented 2 years ago

On my profile, I can see all the GeoPaths that I have completed. Some of them have been archived [12DŚBN] Trójmiasto 2021/2022 https://opencaching.pl/powerTrail.php?ptAction=showSerie&ptrail=1564. There is a link to them on the profile, but the page only says that Ta GeoŚcieżka jest niewidoczna. In my opinion, archived GeoPath should be visible to at least the users who have completed it. For archived caches, it is still possible to display a description etc. so for geoPaths it should be similar

rapotek commented 2 years ago

On my profile, I can see all the GeoPaths that I have completed. Some of them have been archived [12DŚBN] Trójmiasto 2021/2022 https://opencaching.pl/powerTrail.php?ptAction=showSerie&ptrail=1564. There is a link to them on the profile, but the page only says that Ta GeoŚcieżka jest niewidoczna. In my opinion, archived GeoPath should be visible to at least the users who have completed it. For archived caches, it is still possible to display a description etc. so for geoPaths it should be similar

Archived GeoPaths - yes. But here degraded GeoPaths are shown, i.e. these where available caches are not enough to complete a GeoPath, and the meaning of the list is to give information for OCTeam about GeoPaths which should be temporarily disabled. The location of the controller under Admin path suggest this should be used for administrative purposes only.