Prevents geopath multiple publishing, shows correctly status change after button click, fixes #1776

opencaching / opencaching-pl

The source code of Opencaching.PL (and some other domains)

https://opencaching.pl/

GNU General Public License v3.0

22 stars 33 forks source link

Prevents geopath multiple publishing, shows correctly status change after button click, fixes #1776 #2369

Closed rapotek closed 1 year ago

rapotek commented 1 year ago

Substantive changes:

powerTrail/ajaxUpdateStatus.php returns correct JSON now instead of HTML,
src/Models/PowerTrail/PowerTrail.php: canBeOpened() method additionally checks if geopath is published already

The rest of changes are minor logical fixes (like removing this in static method) and code style adjustments.

Remark: IMHO these files need a little deeper refactoring, but the whole geopath creation functionality is promised to be rewritten, so let it be as it is for now.

deg-pl commented 1 year ago

Thanks @rapotek ! It is next step to better OC PL code. I think we can merge this PR. What do you think about it @kojoty ?