search

opencaching / opencaching-pl

The source code of Opencaching.PL (and some other domains)
https://opencaching.pl/
GNU General Public License v3.0
22 stars 33 forks source link

Logbook generator doesn't work. Code refactoring required #655

Open mzylowski opened 8 years ago

mzylowski commented 8 years ago

http://opencaching.pl/logbook.php?logbook_type=2 : selection_031

We didn't change anything in code related with this, so it is probably problem with configuration or something else.

In oc.nl form shows up correctly: selection_032

@deg-pl It is probably post-migration problem so you are pointed here :)

harrieklomp commented 8 years ago

Perhaps this has to do with translations? When change site language to Dutch i get a white screen on oc.nl. All other languages are working correct.

deg-pl commented 8 years ago

No. It's a deeper problem. I'm working on fix. After:

apt install php5.6-mcrypt
service apache2 restart

is a little better, but still is problem ;) BTW: On OC.NL also did not work correctly: logbook1 logbook2

deg-pl commented 8 years ago

logbook.php & /logbook/*.php - this is a VERY ARCHAIC code! It has a lot of errors. This code requires a complete rewrite from scratch. In this form it does not appear to work for many years and is not related to migration (exept absence of php5.6-mcrypt). Uses /logbook/work as temorary space (not default dynamic-files) - we haven't this directory for many years!

We have NO link to this files in all OC code. Only link is at Wiki (https://wiki.opencaching.pl/index.php/U%C5%BCyteczne_pliki_zwi%C4%85zane_z_OC_PL)

My suggestion is to remove this code and link from the Wiki.

mzylowski commented 8 years ago

Actually I know few people who uses it. (You think how I know about these problems? ;]) Also as I know it is only one way to easy create logbook with our date etc. It is important feature, especially for new or inexperienced users.

If we need refactoring we should just do it ;]

Edit: It is on my now, but if somebody want to work on it -> fell free ;]

deg-pl commented 8 years ago

We have a number of very important issues unresolved. Please - resolve first #645, #628, #618, #611, #605, #561

deg-pl commented 6 years ago

mcrypt is deprecated in PHP 7.1 and dropped in PHP 7.2 We use mcrypt only in logbook generator.