cache_locations missing/wrong contents

[andrixnet]

• [ ] cache_locations table apparently gets the adm1 field filled with country name, not from NUTS data, but from country name according to current display language I believe this field should have a consistent value. Field adm3 seems to come from NUTS data, invariable of current display language.

• [ ] fields adm2 and code2 are always empty

• [ ] field adm4 and code4 are always empty These fields are not filled by newcache.php, neither by cache_location update script.

These fields should be filled out properly. It will also help with https://github.com/opencaching/opencaching-pl/issues/103

[deg-pl]

See my comment https://github.com/opencaching/opencaching-pl/pull/814#issuecomment-258228300

[andrixnet]

Let's follow the discussion here. I assume the problems might be related to :

1. newcache
2. editcache
3. cache_locations script for cron

Once these are fixed, a query should be run on each node to make data consistent, since cache_locations script only acts on missing and changed caches.

Since the localized country names were moved to translation files, "countries" table should have had the corresponding columns removed. I am not sure how or if the other columns are used, since many related info is in the settings file already. (see the countries arrays). Still having and using strings from this table contradicts the whole translation infrastructure.

Since that location data is entirely based on NUTS data, I believe the country reference in the table should be the same as the NUTS data. Is the country (adm2) field really used to show cache country? I think not. Are the rest of the region strings also localized? Definitely not.

[andrixnet]

More so, the following only makes sense on OCPL node.

SELECT `countries`.`pl`