Broken statistics by region

opencaching / opencaching-pl

The source code of Opencaching.PL (and some other domains)

https://opencaching.pl/

GNU General Public License v3.0

22 stars 33 forks source link

Open andrixnet opened 7 years ago

andrixnet commented 7 years ago

In general statistics (sitewide):

Statistics by region seem to be broken :

andrixnet commented 7 years ago

Interestingly enough, on OCNL this page seems correct: http://www.opencaching.nl/articles.php?page=s11a

harrieklomp commented 7 years ago

In settingsDefaullt.inc.php there are lines:

/** The filter fragment selecting provinces from nuts_codes table. */
'provinceNutsCondition' => '`code` like \'PL__\'',

This should be moved to your settings.inc.php file an change "PL" to own countrycode.

See also issue https://github.com/opencaching/opencaching-pl/issues/172 where this province problem is mentioned.

andrixnet commented 7 years ago

I see. This warants further investigation. Also related is: https://github.com/opencaching/opencaching-pl/issues/103

andrixnet commented 7 years ago

While that setting is a dirty fix, actually this could / should be done in a better way, taking into consideration the following facts:

one site may serve one or more countries (eg OCNL serving BeNeLux)
settings should define list of countries served, rather then SQL query fragment
one site may use level 2 geographical data, another might need level 3 (eg OCRO)

following5 commented 5 years ago

@andrixnet

http://www.opencaching.ro/articles.php?page=s7 : list is empty http://www.opencaching.ro/articles.php?page=s8 : list is empty

This has been fixed recently. On or multiple countries can be configured in in Config/site.XX.php.

one site may use level 2 geographical data, another might need level 3 (eg OCRO)

General issue for that is now #1838.

So what is left here: