opencaching / opencaching-pl

The source code of Opencaching.PL (and some other domains)
https://opencaching.pl/
GNU General Public License v3.0
22 stars 33 forks source link

Adoption rule? #999

Open andrixnet opened 7 years ago

andrixnet commented 7 years ago

Should the following caches be adoptable?

kojoty commented 7 years ago

Hi, in my opinion: YES, why not? archived - someone wants to adopt and reactivate cache... blocked - cache is blocked because of something, but someone else want's to fix the issues and ask for unblock... not yet published - someone created a cache, but because of something want to give someone else a cache - we block adopting by users under verification, so I can't see any issue...

Can you see any problem see?

andrixnet commented 7 years ago

Archived : either unarchive the cache, then adopt, or adopt as archived, the end result is the same, so there is no reason to not allow it.

Blocked : this is more delicate. @kojoty has detailed the most optimistic point of view. Since blocking is an administrative decision against a certain cache OR a certain user, I would not allow adoption of such caches without admin intervention, considering the reason for the block to no longer be valid either prior to the request, or being invalidated by allowing such request. Either way, I still believe it to be an administrative decision that the reason for blocking it is no longer valid before allowing adoption.

Not yet published: allow it.

For all adotions, I believe the following should still be observed:

What do you thing of this detailing?

andrixnet commented 5 years ago

IMO the adopt page should show a visual indicator of the cache status (active, inactive, archived, not yet published, blocked, etc).

harrieklomp commented 5 years ago

When can a user offer caches for adoption and when can a user accept a cache for adoption? It is not clear (for me) when user can handle adoptions

This question emerges when trying to adopt a cache on OCNA DEVEL site. Bon Echo (has 101 active caches online) wants to offer a cache for adoption to harrieklomp. The warning on his adoption is that he cannot offer caches for adoption. Also there is a warning that harrieklomp is not able to adopt this cache.

andrixnet commented 5 years ago

Indeed, since there are [configurable] rules for hiding caches such as:

I think there should be a clear chart saying in each case how an adotion is handled. This for the use both of the developers to write and maintain the code and the users as documentation.