search

opencad-community / OpenCAD-php

Open Source Computer Aided Dispatch System for Roleplay Communities.
https://opencad.io
GNU General Public License v3.0
103 stars 71 forks source link

Login Error 1.0 #422

Open kevingorman1000 opened 2 years ago

kevingorman1000 commented 2 years ago

Have noticed a bug that doens't allow login within the 1.0 milestone version (Latest canary).

Whenever you login after a session has expired, it still states your session has expired meaning you're unable to login. Possibly to do with the cookie not setting/unsetting?

ItsAGeekThing commented 2 years ago

Have noticed a bug that doens't allow login within the 1.0 milestone version (Latest canary).

Whenever you login after a session has expired, it still states your session has expired meaning you're unable to login. Possibly to do with the cookie not setting/unsetting?

I'll deploy a test instance when I get a chance to attempt reproducing this.

What web server are you testing on and what version of PHP?

kevingorman1000 commented 2 years ago

Used XAMPP and WAMP, both producting this bug. PHP 8.0.13. Disabling the required API auth within oc-includes/apiAuth.php (Setting it to === False) seems to resolve the issue but obviously I know it's disabled the API Auth. I'd imagine there is an issue within that nested if statment somewhere.

Cambridgeport90 commented 2 years ago

I still wouldn’t recommend that configuration for testing… XAMPP/WAMPP aren’t supported for production use, and, my opinion, at least, is that the testing environs should mimic the production environs as much as possible. If anybody disagrees, feel free to speak up.

From: kevingorman1000 @.> Sent: Tuesday, June 14, 2022 8:08 AM To: opencad-app/OpenCAD-php @.> Cc: Subscribed @.***> Subject: Re: [opencad-app/OpenCAD-php] Login Error 1.0 (Issue #422)

Used XAMPP and WAMP, both producting this bug. PHP 8.0.13. Disabling the required API auth within oc-includes/apiAuth.php (Setting it to === False) seems to resolve the issue but obviously I know it's disabled the API Auth. I'd imagine there is an issue within that nested if statment somewhere.

— Reply to this email directly, view it on GitHubhttps://github.com/opencad-app/OpenCAD-php/issues/422#issuecomment-1155096505, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADS4MAGULDIGY43J7Z5KQH3VPBY2NANCNFSM5YTV5BUA. You are receiving this because you are subscribed to this thread.Message ID: @.**@.>>

phillf commented 2 years ago

@Cambridgeport90, I would be careful with what you are saying. It seems like you are insinuating that XAMP/WAMP aren't allowed at all. (Take not that I didn't use the word "supported").

I do think that if one is doing testing/development on Windows they should be using IIS with PHP instead just to avoid the weird shenanigans that default XAMP can pull which we saw with earlier versions of OC. I don't believe we have seen those issues with 1.0.0 as of yet.

kevingorman1000 commented 2 years ago

I have personally developed several web apps within PHP using xampp and haven't every expeirenced any problems when moving it over to a shared/dedicated hosting provider. If you wish, I can set up IIS and use it through that, but most people will use apache when they get shared hosting rather than IIS. I could however be wrong?

phillf commented 2 years ago

@kevingorman1000, like I said, I don't believe we haven't seen those issues from earlier versions of OC in the context of XAMP/LAMP.

Despite the fact XAMP/LAMP isn't recommended I think it's good to have at least one of us developing on top of it just to be sure that we aren't missing anything.

kevingorman1000 commented 2 years ago

I've found that WAMP provides a lot more error logs than XAMPP, I'm happy to carry on using WAMP as I believe the issues I have experienced (IE The API Auth) is related to the actual app rather than the environment. If I start noticing any odd behaviours, I'll be sure to log it.

Cambridgeport90 commented 2 years ago

Thanks for the clarification. That helps.

From: Phill Fernandes @.> Sent: Tuesday, June 14, 2022 8:27 AM To: opencad-app/OpenCAD-php @.> Cc: Katherine M. Moss @.>; Mention @.> Subject: Re: [opencad-app/OpenCAD-php] Login Error 1.0 (Issue #422)

@Cambridgeport90https://github.com/Cambridgeport90, I would be careful with what you are saying. It seems like you are insinuating that XAMP/WAMP aren't allowed at all. (Take not that I didn't use the word "supported").

I do think that if one is doing testing/development on Windows they should be using IIS with PHP instead just to avoid the weird shenanigans that default XAMP can pull which we saw with earlier versions of OC. I don't believe we have seen those issues with 1.0.0 as of yet.

— Reply to this email directly, view it on GitHubhttps://github.com/opencad-app/OpenCAD-php/issues/422#issuecomment-1155116633, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADS4MAHJOWRW6IFZM5SDLDDVPB3CJANCNFSM5YTV5BUA. You are receiving this because you were mentioned.Message ID: @.**@.>>