search

opencadc / caom2tools

Common Archive Observation Model - data engineering tools
2 stars 13 forks source link

CADC-9764 - code review comments from CADC-9555 #148

Closed SharonGoliath closed 3 years ago

SharonGoliath commented 3 years ago

Add the class StorageClientWrapper to hide which client is being used. Remove support for Python 2.

codecov[bot] commented 3 years ago

Codecov Report

Merging #148 (c59138e) into master (2b0cc70) will increase coverage by 0.94%. The diff coverage is 94.17%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #148      +/-   ##
==========================================
+ Coverage   91.98%   92.92%   +0.94%     
==========================================
  Files          22       23       +1     
  Lines        7821     7915      +94     
==========================================
+ Hits         7194     7355     +161     
+ Misses        627      560      -67
Impacted Files Coverage Δ
caom2utils/caom2utils/caomvalidator.py 98.43% <ø> (+1.51%) :arrow_up:
caom2utils/caom2utils/legacy.py 94.87% <78.57%> (+0.48%) :arrow_up:
caom2utils/caom2utils/fits2caom2.py 86.53% <85.71%> (+2.17%) :arrow_up:
caom2utils/caom2utils/data_util.py 99.45% <99.45%> (ø)
caom2utils/caom2utils/__init__.py 100.00% <100.00%> (ø)
caom2utils/caom2utils/polygonvalidator.py 94.31% <100.00%> (+2.09%) :arrow_up:
caom2utils/caom2utils/wcs_util.py 97.37% <100.00%> (+0.25%) :arrow_up:
caom2utils/caom2utils/wcsvalidator.py 95.58% <100.00%> (+2.97%) :arrow_up:
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2b0cc70...c59138e. Read the comment docs.