Error reading caom XML with missing keywords

opencadc / caom2tools

Common Archive Observation Model - data engineering tools

2 stars 13 forks source link

Error reading caom XML with missing keywords #39

Closed dr-rodriguez closed 7 years ago

dr-rodriguez commented 7 years ago

When attempting to read a CAOM2.3 xml with ObservationReader, this line fails due to missing keywords elements. Since keywords are optional, this line should only run if keywords_element is not None.

https://github.com/opencadc/caom2tools/blob/416afc51c4cd3e02d7f493ea9de42b9c51805094/caom2/caom2/obs_reader_writer.py#L264

andamian commented 7 years ago

Ha! We also run into it and I was in the middle of releasing the patch. Fixed and released in caom2-2.3.0a5.