opencadc / caom2tools

Common Archive Observation Model - data engineering tools
2 stars 13 forks source link

Checksum error for target/environment tags #65

Closed dr-rodriguez closed 6 years ago

dr-rodriguez commented 6 years ago

When creating a CAOM observation, if I don't specify the optional observation.target.moving, observation.target.standard, and observation.environment.photometric tags, they don't get written to the XML file. However, when I read in the XML, default values are created and set for them (False, I guess) which means the computed checksum now does not match the stored value.

I've updated our code to always supply a value even if it doesn't have one, but perhaps it's worth double checking how these tags are treated in the ObservationWriter/Reader code.