search

opencadc / vos

client and server implementation of VOSpace specification
GNU Affero General Public License v3.0
2 stars 10 forks source link

Quota plugin cephfs #241

Closed at88mph closed 4 months ago

at88mph commented 5 months ago

Minor cleanup Added quota plugin implementation for CephFS Yet untested, but here for draft review

at88mph commented 4 months ago

OK, I will test vcp today. The Checkstyle changes are complete.

at88mph commented 4 months ago

I also had an interesting case where I reset my ceph.quota.max_bytes to something smaller to test the quota writes, but I neglected to reset the user namespace quota. When the Node loaded, it had the user namespace quota value in the NodeProperty, and wouldn't reset to the QuotaPlugin's value, hence the removal of the old value on line 548 of NodeUtil.

pdowler commented 4 months ago

setting the plain quota prop in user space was a mistake (users could modify it) from previous code; we should probably manually look for and remove that user prop. the workaround is OK for now