opencadc / vostools

VOSpace command line and FUSE clients
https://www.canfar.net/en/docs/storage
12 stars 18 forks source link

Refactored vsync to use threading and work with Python 3 (CADC-8744) #198

Closed andamian closed 2 years ago

andamian commented 2 years ago

This is a IO-bound problem and threading is a better solution: https://realpython.com/python-concurrency/

codecov[bot] commented 2 years ago

Codecov Report

Merging #198 (484c9f4) into master (e11c30a) will increase coverage by 3.71%. The diff coverage is 67.63%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #198      +/-   ##
==========================================
+ Coverage   67.64%   71.35%   +3.71%     
==========================================
  Files          28       28              
  Lines        4036     4008      -28     
==========================================
+ Hits         2730     2860     +130     
+ Misses       1306     1148     -158     
Impacted Files Coverage Δ
vos/vos/vos.py 70.92% <63.63%> (-0.03%) :arrow_down:
vos/vos/commands/vsync.py 69.39% <67.69%> (+57.42%) :arrow_up:
vos/vos/commands/vls.py 62.72% <100.00%> (+0.90%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e11c30a...484c9f4. Read the comment docs.