opencaesar / oml-vision

A VS Code extension providing UI viewpoints for OML models
Other
4 stars 2 forks source link

feat/56-property-commands #58

Closed pogi7 closed 2 months ago

pogi7 commented 2 months ago

Checklist before submitting a merge request

Description of contribution

This feature allows users to add custom commands (SPARQL queries) and run these commands in the property sheet view.

closes #56

Testing performed

How to Test Expected functionality changes

  1. Go to https://github.com/pogi7/kepler16b-example
  2. Switch to main branch
  3. Run git pull
  4. From the command line run ./gradlew load
  5. Wait for that command to finish
  6. Open the Objectives webview
  7. Click the OML Vision Properties panel
  8. Click on any row to select the row then right click the selected row
  9. From the property view update the Label of the row to TEST and press Enter on your keyboard
  10. You should see the table update
  11. From the command line run ./gradlew save
  12. You should see the objectives.oml file change. You can run git status to verify.

Additional context

[If needed, you may add additional context]

pogi7 commented 2 months ago

@aematei The table may not update when changing a property in the property sheet. I'll need to update the table webview using postMessage This has been fixed in the following commit

aematei commented 2 months ago

Hey @pogi7, @greypilgrim and I tested this out but couldn't get past step 9. Here is the error we're getting when we try to update the label:

image
pogi7 commented 2 months ago

Hey @pogi7, @greypilgrim and I tested this out but couldn't get past step 9. Here is the error we're getting when we try to update the label:

image

@aematei This looks like a problem with the controller. Can you send me the log from the Developer: Open Webview Development Tools?