[x] I have done a quick search on the issue tracker to check if the bug report is not redundant
Context
[Give a concise summary of the bug that you have encountered]
Property Panel does not immediately open when clicking a row or node
Steps to reproduce the bug
[List of the steps to reproduce the bug. If relevant, you may add OML Vision code snippets or files that exhibit the bug.]
Start OML Vision for the first time
Click on any row or node
The property panel won't open
Current result
[What currently happens]
The property panel won't open
Expected result
[What is expected to happen instead]
The property panel should immediately open when you click a row or node in the TableView, TreeView, or DiagramView.
Additional context
[Any additional context. If applicable, you may provide screenshots and/or error logs.]
Possible fix
[Not required but you can suggest possible fixes for the bug or link a place in the code that could possibly be causing the bug]
context.subscriptions.push(
vscode.commands.registerCommand(
"oml-vision.showProperties",
async (iri: string = "", webviewType: IWebviewType) => {
let types: string[] = [];
if (iri !== "") {
const rawTypesQuery = getIriTypes(iri);
const sparqlResult = await SparqlClient(rawTypesQuery, "query");
types = sparqlResult.map((entry: ITableData) => entry.type);
}
const propertyData = {
webviewType: webviewType,
rowIri: iri,
tableRowTypes: types,
};
provider.setPendingPayload(propertyData);
// Try to set the properties before focusing.
// If successful, the pendingPayload that was just set
// above will be cleared via the receivedProperties acknowledgement
// in the panel provider. Race condition handling :(
provider.sendMessage({
command: Commands.SHOW_PROPERTIES,
payload: propertyData,
});
provider.showPropertyPanel();
}
)
);
the method provider.showPropertyPanel(); should be called before provider.setPendingPayload(payloadData); to open the property panel immediately.
Technical data
Operating system: Darwin localhost 22.6.0 Darwin Kernel Version 22.6.0: Sun Dec 17 22:12:45 PST 2023; root:xnu-8796.141.3.703.2~2/RELEASE_ARM64_T6000 arm64
Checklist before submitting a bug report
Context
[Give a concise summary of the bug that you have encountered] Property Panel does not immediately open when clicking a row or node
Steps to reproduce the bug
[List of the steps to reproduce the bug. If relevant, you may add OML Vision code snippets or files that exhibit the bug.]
Current result
[What currently happens] The property panel won't open
Expected result
[What is expected to happen instead]
Additional context
[Any additional context. If applicable, you may provide screenshots and/or error logs.]
Possible fix
[Not required but you can suggest possible fixes for the bug or link a place in the code that could possibly be causing the bug]
the method
provider.showPropertyPanel();
should be called beforeprovider.setPendingPayload(payloadData);
to open the property panel immediately.Technical data
Darwin localhost 22.6.0 Darwin Kernel Version 22.6.0: Sun Dec 17 22:12:45 PST 2023; root:xnu-8796.141.3.703.2~2/RELEASE_ARM64_T6000 arm64
1.88.1