opencaesar / oml-vision

A VS Code extension providing UI viewpoints for OML models
Other
4 stars 2 forks source link

Feat/74-json-schemas #84

Closed pogi7 closed 1 month ago

pogi7 commented 1 month ago

Checklist before submitting a merge request

Description of contribution

closes #74

Testing performed

How to Test Expected functionality changes

[Describe expected behaviour changes in steps]

  1. Open this repo in OML Vision https://github.com/UTNAK/kepler16b-using-imce-vocabulary
  2. Click on the eye icon to activate OML Vision
  3. Go into src/vision/commands/compositions.json
  4. Remove line 6
  5. Save the file
  6. You should see a popup or in the console saying Invalid or missing compositions.json.
  7. Undo deleting line 6
  8. Save the file
  9. You should see a popup or in the console saying compositions.json loaded successfully.
  10. Go into src/vision/config/sparqlConfig.json
  11. Remove lines 2-5
  12. Save the file
  13. You should see a popup or in the console saying Invalid or missing sparqlConfig.json.
  14. Undo deleting lines 2-5
  15. Save the file
  16. You should see a popup or in the console saying sparqlConfig.json loaded successfully.
  17. Go into src/vision/viewpoints/pages.json
  18. Remove line 3
  19. Save the file
  20. You should see a popup or in the console saying Invalid or missing pages.json.
  21. Undo deleting line 3
  22. Save the file
  23. You should see a popup or in the console saying pages.json loaded successfully.

Additional context

83 will add to this feature

aematei commented 1 month ago

@pogi7 Okay I was poking around and noticed that the pages menu indeed indicates that there are no available pages to build: image

Also, those viewpoint files in the popups I screenshot earlier seem like they are from the previous repo I was testing with...

pogi7 commented 1 month ago

Everything works fine until pages.json. This is what I see when I both remove and restore line 3: Screenshot 2024-06-10 at 12 08 31 PM

@aematei VSCode only shows 3 notifications by default. The pages.json notification is not showing up. You can check the console log to verify the error.

aematei commented 1 month ago

@pogi7 I checked the log and can confirm that the error is registered. I'll finish up the review.