search

opencaesar / oml-vision

A VS Code extension providing UI viewpoints for OML models
Other
4 stars 2 forks source link

68-allow-to-specify-font-color-in-the-tableview-and-treeview #86

Closed pogi7 closed 1 month ago

pogi7 commented 1 month ago

Checklist before submitting a merge request

Description of contribution

Allows users to specify the font color in the table and tree views using JSON.

closes #68

Testing performed

How to Test Expected functionality changes

[Describe expected behaviour changes in steps]

  1. Open this repo in OML Vision: https://github.com/UTNAK/kepler16b-using-imce-vocabulary
  2. Go to the vision-style-test branch. The PR for the branch is here.
  3. Click on the eye icon to activate OML Vision.
  4. Open the Parameter Table.
  5. Verify that the first 3 rows are formatted.
  6. Close the Parameter Table.
  7. Open the Missions Tree.
  8. Verify that the first 2 rows are formatted.
  9. Close the Missions Tree.
  10. Go into src/vision/viewpoints/tables/parametertable.json.
  11. Remove line 19.
  12. Save the file.
  13. Close and reopen the Parameter Table.
  14. Verify that you see a red popup saying Error: Invalid/Undefined fontStyle.conditional undefined
  15. Undo the change you made in src/vision/viewpoints/tables/parametertable.json.
  16. Go into src/vision/viewpoints/trees/missions.json.
  17. Remove line 15.
  18. Save the file.
  19. Open the Missions Tree.
  20. Verify that you see a red popup saying Error: Invalid/Undefined fontStyle.conditional undefined
  21. Undo the change you made in src/vision/viewpoints/trees/missions.json.

Additional context

[If needed, you may add additional context]

greypilgrim commented 1 month ago

Everything was running fine until action item # 11. I deleted line 19 as requested and reloaded the Parameter Table; there was no change.

pogi7 commented 1 month ago

Everything was running fine until action item # 11. I deleted line 19 as requested and reloaded the Parameter Table; there was no change.

@greypilgrim Try to close and reopen the Parameter Table.

greypilgrim commented 1 month ago

@pogi7 Tried a couple of times, to no avail. There weren't the expected errors in any of the places I checked: the app, debug, notifications, or in the source debug.