opencaesar / owl-adapter

The OML adapter for OWL
Apache License 2.0
0 stars 2 forks source link

[BUG] - CloseDescriptionBundle should look for link and relation instances #41

Closed NicolasRouquette closed 3 years ago

NicolasRouquette commented 3 years ago

Description

A clear and concise description of what the bug is.

Currently, CloseDescriptionBundle.getRelationCounts() calculates the effective cardinality of relations based on link instances only. This omits relation instances.

The manifestation of this problem appears in description bundles in OWL that has axioms constraining the cardinality of restrictions based on the effective cardinality calculation. Since these axioms are restricting the "forward" relation, it is necessary to include instances of both links (i.e., unreified relations) and relations (i.e., reified relations) otherwise the cardinality restriction will be inaccurate.

Steps to Reproduce

Steps to reproduce the behavior:

Expected Behavior

A clear and concise description of what should be the expected behavior.

Additional Context

Enter any other details such as dependencies, environment, examples, etc.

Relevant screenshots

If applicable, add screenshots to help illustrate the issue.