search

opencardev / aasdk

Library to build AndroidAuto headunit emulator
41 stars 33 forks source link

Handle Interleaved Channels #6

Open icecube45 opened 4 years ago

icecube45 commented 4 years ago

aasdk is pretty fractured these days, and this pull request should not be merged due to that. However I'm creating it because of the changes included to src/Messenger/MessageInStream.cpp and include/f1x/aasdk/Messenger/MessageInStream.hpp - the changes made in these files resolves the Interleaved Channel android auto crash, https://github.com/opencardev/crankshaft/issues/404

At least, it's resolved based on my hour of letting it run/testing on a laptop. This has not been run/compiled on a Pi as of yet. I'm unsure of what unforeseen issues might arise with this code change.

rsjudka commented 4 years ago

Just saw this on intelligent-auto:#13, looks like the exact approach I was planning on taking!

I'll probs port this into my app (after doing some cleanup, just some variable name changes that trigger my OCD :p) and do additional testing to see if anything needs refinement.

sjdean commented 4 years ago

Could you advise what you mean by AASDK being pretty fractured?

ivanixiv commented 4 years ago

aasdk is pretty fractured these days, and this pull request should not be merged due to that. However I'm creating it because of the changes included to src/Messenger/MessageInStream.cpp and include/f1x/aasdk/Messenger/MessageInStream.hpp - the changes made in these files resolves the Interleaved Channel android auto crash, opencardev/crankshaft#404

At least, it's resolved based on my hour of letting it run/testing on a laptop. This has not been run/compiled on a Pi as of yet. I'm unsure of what unforeseen issues might arise with this code change.

Hi, how can i apply your fix on my crankshaft?