search

opencardev / openauto

AndroidAuto headunit emulator
GNU General Public License v3.0
134 stars 47 forks source link

Add temp fix for Google Play Services 15.0.90 crash #1

Closed techdev5521 closed 5 years ago

techdev5521 commented 5 years ago

As noted in opencardev/crankshaft#304, with Google Play Services >= 15.0.90 the AndroidAutoEntity::schedulePing() function here:

https://github.com/opencardev/openauto/blob/355c1d3e21e96c61e5bb7fc3d6106329db405162/src/autoapp/Service/AndroidAutoEntity.cpp#L250-L267

The Android Auto UI crashes a few seconds after connection. By commenting out this function, it cannot run and provides a temporary fix lettings users get to and stay in Android Auto's UI without downgrading Google Play Services.

htruong commented 5 years ago

Thanks for the discovery, I have left a comment on your proposed change.

danielgomezrico commented 5 years ago

@htruong what's the difference between this fork and https://github.com/f1xpl/openauto?

I created an PR there https://github.com/f1xpl/openauto/pull/167, excuse me if I didn't waited for @techdev5521 to do it.

htruong commented 5 years ago

This folk may have changes specific to CS. Especially when you see the crankshaft-ng branch.

NiKo2233 commented 5 years ago

Where do I find this File and how can I edit it?

techdev5521 commented 5 years ago

@NiKo2233 The file I've proposed changes to in in openauto/src/autoapp/Service/AndroidAutoEntity.cpp

It is a source code file, not a configuration file. You can download the source code and edit the file with any text editor however you'll need to build your own version of Crankshaft after you edit the file to see the changes.

NiKo2233 commented 5 years ago

Thanks

htruong commented 5 years ago

@techdev5521 If all that we want is to have the ping not run, then perhaps the best place to do that is not commenting out the function.

techdev5521 commented 5 years ago

What would you propose instead? Perhaps only commenting out the call itself here:

https://github.com/opencardev/openauto/blob/355c1d3e21e96c61e5bb7fc3d6106329db405162/src/autoapp/Service/AndroidAutoEntity.cpp#L253-L256

hawkeyexp commented 5 years ago

@techdev5521 thx for your pull request - i disabled the timer also with last online update of the binary but forgot to push the source cause it was a hard month while starting a new job so all was quick and dirty :-) I close the pull and push the current source but it would be great if step in to work together on fixes and enhancements.