search

opencart / opencart-3

OpenCart 3.x
Other
25 stars 31 forks source link

Bootstrap 3.4.1 and sanitize: false, #210

Closed condor2 closed 11 months ago

condor2 commented 11 months ago

If I will do a pull request with Bootstrap 3.4.1, to work popover function is needed to add

sanitize: false,

is ok for you?

TheCartpenter commented 11 months ago

I was about to post for this to @danielkerr since he's the one who accepted your PR. Better, yet, to confirm before integrating this. So far, with the new jQuery version, does this also fix the File Manager issue that was previously reported on the 3.0.x.x repository?

condor2 commented 11 months ago

On 3.0.x.x is same https://github.com/opencart/opencart/commit/25ff238f6ccac5633423de5922b152b4c480d9ee

TheCartpenter commented 11 months ago

Yes, I know. Which is why I am asking, without integrating the sanitize: false right now, does it affect the File Manager from the admin since jQuery has been updated?

condor2 commented 11 months ago

The popup issue is when you update Bootstrap version and not jQuery.

.popover work without sanitize:false if you don't upgrade to Bootstrap 3.4.1

TheCartpenter commented 11 months ago

Ok. Create a PR for it and we'll see to it for a merge.

TheCartpenter commented 11 months ago

Since .popover work without sanitize: false then we may not need to use sanitize: false since we haven't, yet, upgraded to Bootstrap 3.4.1 .

TheCartpenter commented 11 months ago

@condor2: Now that jQuery has been upgraded, to answer your initial question with Bootstrap v3.4.1, you can also give it a try for a PR.

TheCartpenter commented 11 months ago

I also noticed the catalog-end side still uses the old jQuery version. It might need to be upgraded as well.

TheCartpenter commented 11 months ago

It has been merged, now: https://github.com/opencart/opencart-3/pull/211