Closed mbreshock closed 2 years ago
No spelling errors! :tada: Comment updated at 2022-03-29 with changes from 4df45d8f82473d3bcdd498a6663f1b997396b6c2
Re-rendered previews from the latest commit:
Updated at 2022-03-29 with changes from 4df45d8f82473d3bcdd498a6663f1b997396b6c2
fixed air pollution rendering issue, added compilation time to the table here as well.
Purpose/implementation Section
What changes are being implemented in this Pull Request?
moved the section on how to create a case study with the template case study or the makecasestudies app from the end of ch4 to the beginning of ch5
What was your approach?
copied and pasted and added some text to ensure smooth transition
What GitHub issue does your pull request address?
https://github.com/opencasestudies/OCS_Guide/issues/141 "Move creation sections from ch4 to 5"
Tell potential reviewers what kind of feedback you are soliciting.
open to feedback on everything i added, including:
New Content Checklist
[x] New content/chapter is in an Rmd file with this kind of format and headers.
[x] New content/chapter contains Learning Objectives and are in the correct format.
[x] Bookdown successfully re-renders and any new content files have been added to the _bookdown.yml.
[x] Spell check runs successfully in Github actions style-n-check).
[x] Any newly necessary packages that are needed have been added to the Dockerfile and image.
[x] Images are in the correct format for rendering.
[x] Every new image has alt text and is in a Google Slide.
[x] Each slide is described in the notes of the slide so learners relying on a screen reader can access the content. See https://lastcallmedia.com/blog/accessible-comics for more guidance on this.
[x] The color palette choices of the slide are contrasted in a way that is friendly to those with color vision deficiencies. You can check this using Color Oracle.