[Release 8][Fix] Escape non-strings in prefill replacement

opencast-ilias / OpenCast

Opencast plugin for ILIAS LMS. The plugin shows a Opencast series as an ILIAS object. This version of the ILIAS plugin for Opencast is operated and developed collaboratively by a community. The University of Bern acts as coordinative maintainer.

GNU General Public License v3.0

13 stars 14 forks source link

[Release 8][Fix] Escape non-strings in prefill replacement #264

Closed ferishili closed 5 months ago

ferishili commented 6 months ago

This PR fixes #263

Description

please refer to issue.

Solution

adding a string type casting solves the problem!

dagraf commented 5 months ago

Tests of this PR were successfull. Therefore and @Amstutz: Can you please review this PR and comment or merge it, depending on your results? Thank you!

Amstutz commented 5 months ago

thx a lot looks good. however, how did you decide on merging things like this down to 7? Do we merge does things down, even if no strictly required?

Amstutz commented 5 months ago

In a short chat with @chfsx we decided to pick this to 8 as well.