search

opencast-ilias / OpenCast

Opencast plugin for ILIAS LMS. The plugin shows a Opencast series as an ILIAS object. This version of the ILIAS plugin for Opencast is operated and developed collaboratively by a community. The University of Bern acts as coordinative maintainer.
GNU General Public License v3.0
12 stars 14 forks source link

The Opencast object cannot be deleted #275

Closed ralede closed 2 months ago

ralede commented 2 months ago

The Opencast object cannot be deleted. An error message appears.

To Reproduce Steps to reproduce the behavior:

  1. Create a new or choose an existing Opencast object
  2. Click on 'Delete'
  3. The error message appears and the Opencast object still exists

Expected behavior The Opencast object should be deleted without an error message

Log TypeError thrown with message "Argument 2 passed to ilObjOpenCastGUI::showDeleteConfirmation() must be of the type bool, null given, called in /var/www/ilias/Customizing/global/plugins/Services/Repository/RepositoryObject/OpenCast/classes/trait.ilObjShowDuplicates.php on line 44"

Stacktrace:

8 TypeError in /var/www/ilias/Customizing/global/plugins/Services/Repository/RepositoryObject/OpenCast/classes/trait.ilObjShowDuplicates.php:52

7 ilObjOpenCastGUI:showDeleteConfirmation in /var/www/ilias/Customizing/global/plugins/Services/Repository/RepositoryObject/OpenCast/classes/trait.ilObjShowDuplicates.php:44

6 ilObjOpenCastGUI:deleteObject in /var/www/ilias/Customizing/global/plugins/Services/Repository/RepositoryObject/OpenCast/classes/class.ilObjOpenCastGUI.php:187

5 ilObjOpenCastGUI:executeCommand in /var/www/ilias/Services/UICore/classes/class.ilCtrl.php:217

4 ilCtrl:forwardCommand in /var/www/ilias/Services/Repository/classes/class.ilRepositoryGUI.php:375

3 ilRepositoryGUI:show in /var/www/ilias/Services/Repository/classes/class.ilRepositoryGUI.php:337

2 ilRepositoryGUI:executeCommand in /var/www/ilias/Services/UICore/classes/class.ilCtrl.php:217

1 ilCtrl:forwardCommand in /var/www/ilias/Services/UICore/classes/class.ilCtrl.php:178

0 ilCtrl:callBaseClass in /var/www/ilias/ilias.php:23

Environment (please complete the following information):

dagraf commented 2 months ago

I can reproduce this bug on our installation. @chfsx Can you have a look at it in fix it as soon as possible? Thx!

rfcmaXi commented 2 months ago

https://github.com/opencast-ilias/OpenCast/blob/release_7/classes/trait.ilObjShowDuplicates.php#L44 $a_error?

dagraf commented 2 months ago

Testing of the bugfix in https://github.com/opencast-ilias/OpenCast/pull/284 by @tscheere was succesfull. Therefore, I close this issue.