Open ferishili opened 2 months ago
Bug: Workflow parameter "straightToPublishing" has no effect when the upload of subtitles is activated in the config
Steps to reproduce:
Bug: Workflow parameter "straightToPublishing" has no effect when the upload of subtitles is activated in the config
Steps to reproduce:
1. Have the option "Enable Subtitle Upload" activated. 2. Have the Workflow Parameter "straightToPublishing" configured as "Show in Form (checkbox selected" (Usage for Admins, Title "Automatisch publizieren"). 3. Upload a video and leave the option "Automatische publizieren" deactivated. 4. See error: The video does not get published (because the workflow parameter for straightToPublishing is set to 'false' in Opencast.
The new commits fixed this issue.
Our testings were all successfull. We tested with srt- and vtt-files and with german, english and french subtitles. Everything worked as expected. @ferishili or @chfsx: Should we now take care of merging this PR which brings in a new feature or would you recommend us to wait for testresults of the remaining new features and publish a new version of the plugin?
@chfsx: Could you please review this PR?
I then would like to discuss how to proceed with the PRs that introduce the new features in our next community meeting.
This PR fixes #10
Description
Users are now able to upload (one) subtitle file (with configured accepted file type) for each (configured) language together with uploading a video. More info in the issue's description!
Requirement
release_8
)How it works
Plugin Config (Admin side)
User side
Subtitle Conversion
Due to the fact that, Opencast 15 handles Subtitles as first class citizens (more info), by default Opencast looks for and processes WebVTT formats, therefore, we need to simply convert other formats to VTT using FFmpeg!
In Opencast (not possible)
It is possible to convert to VTT using FFmpeg in Workflows (partial-ingest) using encode operation, however, as we have to also pass Tags and work with tags, it is currently a limitation in Opencast by which workflow operations cannot copy tags over from one track to another. (I could not find any way, if you know such way please let me know!)
In ILIAS (possible and included)
In order for this to happen in ILIAS, one must install FFmpeg and configure it in ILIAS (Optional Dependencies for ILIAS).
NOTE: This PR may receive further updates! Your feedback and opinions are very welcome.
NOTE: This depends on #299, for passing workflow params to ingest!